[0.11.x] Fix cloning with Azure DevOps Git #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tomkennedy513
commented
Oct 2, 2023
tomkennedy513
commented
- remove multi_ack and multi_ack_detailed from unsupported capabilities
- see https://github.com/go-git/go-git/blob/52c2972976737a00fce91d7deb1278a6a460cae6/_examples/azure_devops/main.go\#L21-L36 for more info
- we should be able to remove this once go-git implements full support for v2 git with multi_ack
tomkennedy513
force-pushed
the
fix-azure-devops-0.11
branch
from
6e66f5a to
99ac727
Compare
This was referenced Oct 4, 2023
Signed-off-by: Tom Kennedy <ktom@vmware.com>
- remove multi_ack and multi_ack_detailed from unsupported capabilities - see https://github.com/go-git/go-git/blob/52c2972976737a00fce91d7deb1278a6a460cae6/_examples/azure_devops/main.go\#L21-L36 for more info - we should be able to remove this once go-git implements full support for v2 git with multi_ack Signed-off-by: Tom Kennedy <ktom@vmware.com>
- Also pinning to a commit so this doesn't happen in the future Signed-off-by: Tom Kennedy <ktom@vmware.com>
Signed-off-by: Tom Kennedy <10608054+tomkennedy513@users.noreply.github.com>
tomkennedy513
force-pushed
the
fix-azure-devops-0.11
branch
from
e7df35c to
295f111
Compare
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## release/v0.11.x #1339 +/- ##
===================================================
+ Coverage 67.81% 67.83% +0.01%
===================================================
Files 132 132
Lines 8066 8071 +5
===================================================
+ Hits 5470 5475 +5
Misses 2166 2166
Partials 430 430
|
sambhav
approved these changes
Oct 9, 2023
matthewmcnew
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.