Add scripts to build kpack with Tilt #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #1345 +/- ##
==========================================
- Coverage 67.41% 67.34% -0.08%
==========================================
Files 133 133
Lines 8093 8210 +117
==========================================
+ Hits 5456 5529 +73
- Misses 2200 2231 +31
- Partials 437 450 +13 |
chenbh
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces tilt to kpack. Each image is built individually. The triggers may be slightly off so they may need to be tweaked but I have tested that kpack does deploy and function properly.
The config-logging configmap needs to be commented out for the k8s_kind image swapping to function properly.
The reason for both pack and local resources are for live loading. I am still working on validating that this works properly but wanted to put something up in case there was any feedback since I am just getting started with kpack. Any feedback welcome!