[0.11.x] Bump deps and go version for CVE fixes #1411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkennedy513
approved these changes
Nov 23, 2023
i think we were relying on the go toolchain available inside the runner image, which could be out of date. Instead we should use the setup-go action which should have the latest version of the toolchain Signed-off-by: Bohan Chen <bohanc@vmware.com>
otherwise it'll use the system toolchain to run report.go, which will fail when it encounters the new `toolchain` directive in the root go.mod Signed-off-by: Bohan Chen <bohanc@vmware.com>
chenbh
force-pushed
the
0-11-4-dep-bump
branch
from
fe999e1 to
1101381
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release/v0.11.x #1411 +/- ##
================================================
Coverage 67.83% 67.83%
================================================
Files 132 132
Lines 8071 8071
================================================
Hits 5475 5475
Misses 2166 2166
Partials 430 430 ☔ View full report in Codecov by Sentry. |
chenbh
force-pushed
the
0-11-4-dep-bump
branch
from
1101381 to
ef6f9fe
Compare
Signed-off-by: Bohan Chen <bohanc@vmware.com>
chenbh
force-pushed
the
0-11-4-dep-bump
branch
from
ef6f9fe to
8bf16f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still 2 CVEs left, but bumping them is non-trivial and IMO not worth the hassle
github.com/docker/docker: Only affects docker daemon, we're using it as a librarygh.neting.cc/sigstore/cosign/v2: Bumping this requires k8s api v0.28, which is something we're not doing in a patch release