Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added timestamp boolean for TailBuildName to be used in kpcli #1458

Merged
merged 1 commit into from
Dec 19, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added timestamp boolean for TailBuildName to be used in kpcli
  • Loading branch information
pviraj59 committed Dec 18, 2023
commit 2e3324ee8a9ed1cf819b9ac6ed30413c5d10bda6
4 changes: 2 additions & 2 deletions pkg/logs/build_logs.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ func (c *BuildLogsClient) GetImageLogs(ctx context.Context, writer io.Writer, im
}, false, false)
}

func (c *BuildLogsClient) TailBuildName(ctx context.Context, writer io.Writer, namespace string, buildName string) error {
func (c *BuildLogsClient) TailBuildName(ctx context.Context, writer io.Writer, namespace string, buildName string, timestamp bool) error {
return c.tailPods(ctx, writer, namespace, metav1.ListOptions{
Watch: true,
LabelSelector: fmt.Sprintf("%s=%s", buildapi.BuildLabel, buildName),
}, true, true, false)
}, true, true, timestamp)
}

func (c *BuildLogsClient) tailPods(ctx context.Context, writer io.Writer, namespace string, listOptions metav1.ListOptions, exitPodComplete bool, follow, timestamp bool) error {
Expand Down
Loading