Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for platform api 0.2 #267

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Add support for platform api 0.2 #267

merged 1 commit into from
Jan 15, 2020

Conversation

matthewmcnew
Copy link
Collaborator

Signed-off-by: Arjun Sreedharan asreedharan@pivotal.io

@codecov-io
Copy link

Codecov Report

Merging #267 into master will increase coverage by 0.75%.
The diff coverage is 97.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #267      +/-   ##
==========================================
+ Coverage   66.09%   66.85%   +0.75%     
==========================================
  Files          76       77       +1     
  Lines        3014     3089      +75     
==========================================
+ Hits         1992     2065      +73     
- Misses        771      775       +4     
+ Partials      251      249       -2
Impacted Files Coverage Δ
pkg/reconciler/v1alpha1/build/build.go 68.62% <ø> (ø) ⬆️
pkg/cnb/cnb_metadata.go 66.26% <100%> (ø) ⬆️
pkg/buildpod/generator.go 60% <100%> (+0.74%) ⬆️
pkg/apis/build/v1alpha1/build.go 32.6% <20%> (-13.3%) ⬇️
pkg/apis/build/v1alpha1/build_pod.go 97.69% <98.67%> (-0.38%) ⬇️
pkg/apis/experimental/v1alpha1/stack_validation.go 88.88% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4c42b9...3dd42be. Read the comment docs.

@matthewmcnew matthewmcnew marked this pull request as ready for review January 15, 2020 15:36
Signed-off-by: Arjun Sreedharan <asreedharan@pivotal.io>
Copy link

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thisisnotashwin thisisnotashwin merged commit a69b356 into master Jan 15, 2020
@thisisnotashwin thisisnotashwin deleted the plaform-02 branch January 15, 2020 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants