Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cowardly refuse to attempt builds with a platform api > 0.2 #278

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

matthewmcnew
Copy link
Collaborator

  • Save build pod creation error in build status

- Save build pod creation error in build status
@codecov-io
Copy link

Codecov Report

Merging #278 into master will increase coverage by 0.26%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #278      +/-   ##
==========================================
+ Coverage    66.9%   67.17%   +0.26%     
==========================================
  Files          76       77       +1     
  Lines        3082     3101      +19     
==========================================
+ Hits         2062     2083      +21     
+ Misses        772      771       -1     
+ Partials      248      247       -1
Impacted Files Coverage Δ
pkg/apis/build/v1alpha1/build_pod.go 97.69% <100%> (+0.02%) ⬆️
pkg/apis/build/v1alpha1/build_lifecycle.go 100% <100%> (ø)
pkg/reconciler/v1alpha1/build/build.go 72.72% <81.25%> (+4.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fcd05a...ca822a6. Read the comment docs.

@thisisnotashwin
Copy link

thisisnotashwin commented Jan 23, 2020

Additionally, it would be nice, if we are provided builders that have a lifecycle with a Platform API of > 0.2, we dont mark them as ready, and keep condition false with an unsupported version error message. I am ok with that being a separate PR.

return pod, nil
podConfig, err := c.PodGenerator.Generate(build)
if err != nil {
return nil, controller.NewPermanentError(err)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@matthewmcnew matthewmcnew merged commit d4cc9f2 into master Jan 24, 2020
@matthewmcnew matthewmcnew deleted the platform-check branch January 24, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants