Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exit with access error if rebase container cannot access images #427

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Exit with access error if rebase container cannot access images #427

merged 1 commit into from
Jul 1, 2020

Conversation

matthewmcnew
Copy link
Collaborator

  • This prevents opaque errors where the rebase would fail trying to read labels on a inaccessible image:
ERROR: rebase working image: rebase: could not find base layer in image

@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2020 •
edited
Loading

Codecov Report

Merging #427 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #427   +/-   ##
=======================================
  Coverage   67.33%   67.33%           
=======================================
  Files          85       85           
  Lines        3612     3612           
=======================================
  Hits         2432     2432           
  Misses        894      894           
  Partials      286      286

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8855f86...cd40e47. Read the comment docs.

@matthewmcnew
Exit with access error if rebase container cannot access previous app…
cd40e47 
… image or run image

- This prevents opaque errors where the rebase would fail trying to read labels on a inaccessible image:
```
ERROR: rebase working image: rebase: could not find base layer in image
```
@matthewmcnew matthewmcnew force-pushed the better-rebase-error branch from 2998cdf to cd40e47 Compare June 30, 2020 18:11
@matthewmcnew matthewmcnew merged commit 39b4902 into master Jul 1, 2020
@matthewmcnew matthewmcnew deleted the better-rebase-error branch July 1, 2020 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@tylerphelan tylerphelan tylerphelan approved these changes

@sukhil-suresh sukhil-suresh sukhil-suresh approved these changes

@djoyahoy djoyahoy Awaiting requested review from djoyahoy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@matthewmcnew @codecov-commenter @sukhil-suresh @tylerphelan @thisisnotashwin