Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display buildpack homepage on cb, ccb and store status #448

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

sukhil-suresh
Copy link
Contributor

Added homepage field to BuildpackMetadata and BuildpackageInfo

@codecov-commenter
Copy link

Codecov Report

Merging #448 into master will increase coverage by 0.02%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage   67.43%   67.46%   +0.02%     
==========================================
  Files          85       85              
  Lines        3630     3633       +3     
==========================================
+ Hits         2448     2451       +3     
  Misses        895      895              
  Partials      287      287              
Impacted Files Coverage Δ
pkg/apis/build/v1alpha1/buildpack_metadata.go 0.00% <ø> (ø)
pkg/blob/fetch.go 58.87% <50.00%> (ø)
pkg/cnb/cnb_metadata.go 66.66% <100.00%> (+0.40%) ⬆️
pkg/cnb/create_builder.go 76.19% <100.00%> (+0.58%) ⬆️
pkg/cnb/remote_store_reader.go 73.84% <100.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68925ea...df3c541. Read the comment docs.

@sukhil-suresh sukhil-suresh marked this pull request as ready for review July 21, 2020 20:15
Signed-off-by: Sukhil Suresh <ssukhil@vmware.com>
@sukhil-suresh sukhil-suresh force-pushed the pr_buildpack_homepage branch from df3c541 to 5b18e46 Compare July 22, 2020 16:14
@sukhil-suresh sukhil-suresh merged commit 5ec122f into master Jul 22, 2020
@sukhil-suresh sukhil-suresh deleted the pr_buildpack_homepage branch July 22, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants