Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Images/Builds resources to select nodes and configure the scheduling algorithm #812

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

matthewmcnew
Copy link
Collaborator

@matthewmcnew matthewmcnew commented Aug 25, 2021

This RFC addresses #621

Readable

rfcs/0000-template.md Outdated Show resolved Hide resolved
@tylerphelan
Copy link
Contributor

can't think of any issues with this

@dumez-k dumez-k self-requested a review September 7, 2021 14:28
@matthewmcnew matthewmcnew force-pushed the rfc-image-build-node-selection branch 2 times, most recently from b8feb84 to 8ddcdfd Compare September 8, 2021 22:53
@matthewmcnew matthewmcnew changed the title [WIP] Allow Images/Builds resources to select nodes Allow Images/Builds resources to select nodes and configure the scheduling algorithm Sep 8, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2021

Codecov Report

Merging #812 (7f0c3e4) into main (1f5654b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #812   +/-   ##
=======================================
  Coverage   67.80%   67.80%           
=======================================
  Files         112      112           
  Lines        4846     4846           
=======================================
  Hits         3286     3286           
  Misses       1191     1191           
  Partials      369      369           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f5654b...7f0c3e4. Read the comment docs.

@tylerphelan tylerphelan self-requested a review September 9, 2021 14:11
@tylerphelan tylerphelan force-pushed the rfc-image-build-node-selection branch from 8ddcdfd to 7f0c3e4 Compare September 22, 2021 14:12
@tylerphelan tylerphelan merged commit 747d2fd into main Sep 22, 2021
@tylerphelan tylerphelan deleted the rfc-image-build-node-selection branch September 22, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants