Validate that image cache size does not change when the storage class is not expandable #813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylerphelan
changed the title
tylerphelan
requested review from
sambhav,
matthewmcnew,
dumez-k and
tomkennedy513
Codecov Report
@@ Coverage Diff @@
## main #813 +/- ##
==========================================
+ Coverage 68.29% 68.36% +0.07%
==========================================
Files 117 117
Lines 4961 4972 +11
==========================================
+ Hits 3388 3399 +11
Misses 1201 1201
Partials 372 372
Continue to review full report at Codecov.
|
sambhav
approved these changes
Aug 26, 2021
tomkennedy513
approved these changes
Aug 26, 2021
matthewmcnew
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #795 just rebased and added some context to the cannot-expand validation error message
Fix #775