deprecate notary support in v1alpha2 #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
tomkennedy513
commented
Sep 28, 2021
tomkennedy513
commented
- only allow the kpack controller to create builds with notary configs
tomkennedy513
requested review from
jromero,
matthewmcnew,
tylerphelan and
dumez-k
tomkennedy513
force-pushed
the
deprecate-notary
branch
from
526d73b to
bf6b013
Compare
jromero
approved these changes
Sep 28, 2021
dumez-k
approved these changes
Sep 28, 2021
Codecov Report
@@ Coverage Diff @@
## main #836 +/- ##
==========================================
+ Coverage 68.72% 68.77% +0.05%
==========================================
Files 114 114
Lines 5042 5051 +9
==========================================
+ Hits 3465 3474 +9
Misses 1207 1207
Partials 370 370
Continue to review full report at Codecov.
|
| @@ -169,7 +177,7 @@ func (ib *ImageBuild) Validate(ctx context.Context) *apis.FieldError { | |||
|
|
|||
| func validateCnbBindingsEmpty(bindings corev1alpha1.CNBBindings) *apis.FieldError { | |||
| if len(bindings) > 0 { | |||
| return apis.ErrDisallowedFields("") | |||
| return apis.ErrGeneric("CNB binding support has been deprecated in v1alpha2, please use v1alpha1 for CNB bindings", "") | |||
matthewmcnew
approved these changes
Sep 28, 2021
tomkennedy513
force-pushed
the
deprecate-notary
branch
from
bf6b013 to
109e912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.