Provide serviceAccountRef name/namespace on lifecycle-image configmap #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
matthewmcnew
commented
Sep 28, 2021
matthewmcnew
commented
- This allows the lifecycle image to live in a registry which requires credentials.
- These credentials can be dynamically updated by updating the credentials directly in k8s api.
- The lifecycle image is no longer immediately read on controller start because the configmap is needed with the full service acocunt references.
- This allows the lifecycle image to live in a registry which requires credentials. - These credentials can be dynamically updated by updating the credentials directly in k8s api. - The lifecycle image is no longer immediately read on controller start because the configmap is needed with the full service acocunt references.
matthewmcnew
force-pushed
the
read-lifecycle-creds-configmap
branch
from
5d54138 to
461adc7
Compare
tomkennedy513
approved these changes
Sep 28, 2021
Codecov Report
@@ Coverage Diff @@
## main #837 +/- ##
==========================================
- Coverage 68.72% 68.64% -0.09%
==========================================
Files 114 114
Lines 5042 5045 +3
==========================================
- Hits 3465 3463 -2
- Misses 1207 1210 +3
- Partials 370 372 +2
Continue to review full report at Codecov.
|
dumez-k
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.