Explicitly add listKind to CRDs #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomkennedy513
approved these changes
Oct 18, 2021
|
LGTM but curious if there was any background behind this change. |
tylerphelan
changed the title
- This makes installs schematically idempotent - Rename stack config file to more accurate clusterstack.yaml
tylerphelan
force-pushed
the
list-kind
branch
from
bc3d11c to
21c09f4
Compare
This just makes the installations of kpack a bit more idempotent. One deployment tool we use kapp controller will basically check for diffs after an installation and this change ensures there are no diffs. |
Codecov Report
@@ Coverage Diff @@
## main #860 +/- ##
=======================================
Coverage 67.64% 67.64%
=======================================
Files 113 113
Lines 5013 5013
=======================================
Hits 3391 3391
Misses 1259 1259
Partials 363 363 Continue to review full report at Codecov.
|
matthewmcnew
approved these changes
Oct 19, 2021
tylerphelan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make kpack installation configuration idempotent