Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lifecycle import code to 0.13.4 #935

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Conversation

tylerphelan
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2022

Codecov Report

Merging #935 (89d3523) into main (3771025) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #935   +/-   ##
=======================================
  Coverage   69.64%   69.64%           
=======================================
  Files         119      119           
  Lines        5379     5379           
=======================================
  Hits         3746     3746           
  Misses       1268     1268           
  Partials      365      365           
Impacted Files Coverage Δ
pkg/buildpod/generator.go 66.66% <100.00%> (ø)
pkg/cnb/cnb_metadata.go 46.29% <100.00%> (ø)
pkg/cosign/image_signer.go 86.66% <100.00%> (ø)
pkg/notary/image_signer.go 71.60% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3771025...89d3523. Read the comment docs.

@tylerphelan tylerphelan force-pushed the bump-lifecycle-code-0.13.4 branch from cb80543 to 89d3523 Compare March 11, 2022 19:52
@matthewmcnew
Copy link
Collaborator

Resolves: #919

@matthewmcnew matthewmcnew linked an issue Mar 11, 2022 that may be closed by this pull request
Copy link
Collaborator

@matthewmcnew matthewmcnew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also bump here: https://github.com/pivotal/kpack/blob/main/hack/lifecycle/main.go. Maybe as a separate PR.

@tylerphelan tylerphelan merged commit 80f61c2 into main Mar 15, 2022
@tylerphelan tylerphelan deleted the bump-lifecycle-code-0.13.4 branch March 15, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utilize Lifecycle 0.13.x in rebase container
5 participants