Represent a template #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a template and the mechanism to ask questions form template prompts Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
sambhav
approved these changes
Dec 20, 2022
dfreilich
reviewed
Dec 20, 2022
| "github.com/sclevine/spec/report" | ||
| ) | ||
|
|
||
| func TestIternal(t *testing.T) { |
| func testReadPrompt(t *testing.T, when spec.G, it spec.S) { | ||
| when("Reading a prompt file", func() { | ||
| it("reads a correct prompt file", func() { | ||
| tmpDir, _ := ioutil.TempDir("", "test") |
There was a problem hiding this comment.
nit: You can use t.TempDir() to simplify this, and not require the explicit os.RemoveAll
Comment on lines
+27
to
+29
| f, _ := os.Create(promptFile) | ||
| f.Write([]byte(correctPromptFile)) | ||
| f.Close() |
There was a problem hiding this comment.
nit: You can use os.WriteFile() to simplify this, if you're anyways closing the file descriptor here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a template and the mechanism to ask questions form template prompts
Signed-off-by: Aidan Delaney adelaney21@bloomberg.net