Transform source files #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AidanDelaney
force-pushed
the
transform
branch
2 times, most recently
from
6286d0f to
de93930
Compare
sambhav
reviewed
Dec 28, 2022
pkg/internal/transform_test.go
Outdated
|
|
||
| "github.com/buildpacks/scafall/pkg/internal" | ||
|
|
||
| h "github.com/buildpacks/pack/testhelpers" |
There was a problem hiding this comment.
We should not have circular dependencies between pack and scafall. scafall should be unaware of pack. This will cause issues down the road when pack imports scafall.
There was a problem hiding this comment.
Thanks. I've switched to testify's asserts and I've broken the circular import.
AidanDelaney
force-pushed
the
transform
branch
from
de93930 to
87f9c12
Compare
Given a representation of a file from a source repository, transform it into its destination in a target directory. This includes substituting variables in the file path, in any text file and not-substituting unknown variables. Signed-off-by: Aidan Delaney <adelaney21@bloomberg.net>
AidanDelaney
force-pushed
the
transform
branch
from
87f9c12 to
aa7e114
Compare
sambhav
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a representation of a file from a source repository, transform it into its destination in a target directory. This includes substituting variables in the file path, in any text file and not-substituting unknown variables.