Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The platform won't delete cache images #594

Merged
merged 4 commits into from
Aug 11, 2023
Merged

The platform won't delete cache images #594

merged 4 commits into from
Aug 11, 2023

Conversation

dlion
Copy link
Member

@dlion dlion commented Jun 29, 2023

@dlion dlion requested a review from a team as a code owner June 29, 2023 13:20
@dlion dlion mentioned this pull request Jun 29, 2023
Closed
3 tasks
AidanDelaney
AidanDelaney requested changes Jul 4, 2023
View reviewed changes
Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have one stylistic comment about Title Case which I'd like you to adopt. I also have a suggestion to include a pointer to the Docker documentation. Please feel free to accept/reject or edit the suggestion.

content/docs/app-developer-guide/using-cache-image.md Outdated Show resolved Hide resolved
content/docs/app-developer-guide/using-cache-image.md Outdated Show resolved Hide resolved
@dlion
Copy link
Member Author

dlion commented Jul 4, 2023

Thanks, @AidanDelaney, I accepted/committed your suggestions 🙏🏼
Now it's just a matter of having this PR merged (buildpacks/lifecycle#1136), but I guess it requires talking about it in the next working group

@dlion dlion force-pushed the 268-stop-deleting-cache-images branch from 0506efa to 0f99b48 Compare July 13, 2023 08:56
@dlion
Copy link
Member Author

dlion commented Jul 13, 2023

Hi @AidanDelaney , now that the PR buildpacks/lifecycle#1136 has been merged I think we can merge this as well 😄

Add a subsection and a note to warn the user that the cache won't be …
e5334d6 
…clean up by the platform

Signed-off-by: Domenico Luciani <dluciani@vmware.com>
@dlion dlion force-pushed the 268-stop-deleting-cache-images branch from 0f99b48 to e5334d6 Compare July 18, 2023 08:43
Domenico Luciani and others added 2 commits July 25, 2023 10:47
@AidanDelaney
Update content/docs/app-developer-guide/using-cache-image.md
da7deaa 
Co-authored-by: Aidan Delaney <aidan.delaney@gmail.com>
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
@AidanDelaney
Update content/docs/app-developer-guide/using-cache-image.md
08f9631 
Co-authored-by: Aidan Delaney <aidan.delaney@gmail.com>
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
@dlion
Copy link
Member Author

dlion commented Jul 25, 2023

Thank you for those suggestions @AidanDelaney , I accepted it! 🚀

@AidanDelaney AidanDelaney merged commit 46eedd5 into buildpacks:main Aug 11, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 11, 2023
@AidanDelaney
Merge pull request #594 from dlion/268-stop-deleting-cache-images
bd4002e 
The platform won't delete cache images
@dlion dlion deleted the 268-stop-deleting-cache-images branch August 18, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natalieparellano natalieparellano natalieparellano left review comments

@AidanDelaney AidanDelaney AidanDelaney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlion @AidanDelaney @natalieparellano