Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand slice layers page #752

Merged

Conversation

hyounes4560
Copy link
Contributor

Closes #751

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560 hyounes4560 requested a review from a team as a code owner July 18, 2024 02:40
Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. You can ignore the vale errors (I'm fixing those in #756). Feel free to adopt or reject the vale recommendations.

@hyounes4560
Copy link
Contributor Author

@AidanDelaney how to reject the vale recommendations? thank you

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
hyounes4560 and others added 2 commits July 24, 2024 15:02
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560
Copy link
Contributor Author

@AidanDelaney @natalieparellano can we merge this if okay?

Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT. I left a small nit

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@natalieparellano natalieparellano merged commit c81009f into buildpacks:main Jul 31, 2024
4 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 31, 2024
@hyounes4560 hyounes4560 deleted the expand-slice-layers-page branch August 7, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand slice layers page
3 participants