Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expands platform lifecycle tutorial #769

Merged
merged 17 commits into from
Oct 22, 2024
Merged

expands platform lifecycle tutorial #769

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d8f3a6e
expands platform lifecycle tutorial
hyounes4560 Sep 23, 2024
6ccc5c9
adds more content & reviewer feedback
hyounes4560 Sep 23, 2024
751f86b
adds detect section & updates few links
hyounes4560 Sep 24, 2024
bb2241b
edits the last section
hyounes4560 Sep 24, 2024
363b82e
adds reviewer feedback
hyounes4560 Sep 30, 2024
d17e96a
adds more reviewer feedback
hyounes4560 Oct 1, 2024
14353cd
Fix recursive copy of samples
AidanDelaney Oct 4, 2024
493f3bc
implements reviewer feedback
hyounes4560 Oct 4, 2024
460c91b
Merge branch 'lifecycle-tutorial' of github.com:hyounes4560/docs into…
hyounes4560 Oct 4, 2024
84c25c7
adds latest reviewer comments
hyounes4560 Oct 7, 2024
21a4b89
adds reviewer final feedback
hyounes4560 Oct 10, 2024
f159da1
Merge branch 'main' into lifecycle-tutorial
hyounes4560 Oct 10, 2024
78ba3ce
adds minor update
hyounes4560 Oct 10, 2024
4c7092c
adds reviewer code suggestions
hyounes4560 Oct 17, 2024
3124781
Merge branch 'main' into lifecycle-tutorial
AidanDelaney Oct 17, 2024
28136b2
Merge branch 'main' into lifecycle-tutorial
AidanDelaney Oct 22, 2024
1cb041a
Merge branch 'main' into lifecycle-tutorial
AidanDelaney Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/docs/for-platform-operators/concepts/lifecycle/analyze.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
Starting from `Platform API 0.7`, the `analyze` phase runs before the `detect` phase in order to validate registry access for all images that are used during the `build` as early as possible. In this way it provides faster failures for end users. The other responsibilities of the `analyzer` were moved to the `restorer`.\
For more information, please see [this migration guide][platform-api-06-07-migration].

The `lifecycle` should attempt to locate a reference to the latest `OCI image` from a previous build that is readable and was created by the `lifecycle` using the same application source code. If no such reference is found, the `analysis` is skipped.\
The `lifecycle` should attempt to locate a reference to the latest `OCI image` from a previous build that is readable and was created by the `lifecycle` using the same application source code. If no such reference is found, the `analysis` is skipped.

Check warning on line 18 in content/docs/for-platform-operators/concepts/lifecycle/analyze.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Google.Contractions] Use 'that's' instead of 'that is'.

Raw Output:
{"message": "[Google.Contractions] Use 'that's' instead of 'that is'.", "location": {"path": "content/docs/for-platform-operators/concepts/lifecycle/analyze.md", "range": {"start": {"line": 18, "column": 102}}}, "severity": "INFO"}

Check warning on line 18 in content/docs/for-platform-operators/concepts/lifecycle/analyze.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Google.Passive] In general, use active voice instead of passive voice ('was created').

Raw Output:
{"message": "[Google.Passive] In general, use active voice instead of passive voice ('was created').", "location": {"path": "content/docs/for-platform-operators/concepts/lifecycle/analyze.md", "range": {"start": {"line": 18, "column": 123}}}, "severity": "INFO"}

Check warning on line 18 in content/docs/for-platform-operators/concepts/lifecycle/analyze.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Google.WordList] Use 'app' instead of 'application'.

Raw Output:
{"message": "[Google.WordList] Use 'app' instead of 'application'.", "location": {"path": "content/docs/for-platform-operators/concepts/lifecycle/analyze.md", "range": {"start": {"line": 18, "column": 169}}}, "severity": "WARNING"}

Check warning on line 18 in content/docs/for-platform-operators/concepts/lifecycle/analyze.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Google.Passive] In general, use active voice instead of passive voice ('is found').

Raw Output:
{"message": "[Google.Passive] In general, use active voice instead of passive voice ('is found').", "location": {"path": "content/docs/for-platform-operators/concepts/lifecycle/analyze.md", "range": {"start": {"line": 18, "column": 215}}}, "severity": "INFO"}

Check warning on line 18 in content/docs/for-platform-operators/concepts/lifecycle/analyze.md

View workflow job for this annotation

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Google.Passive] In general, use active voice instead of passive voice ('is skipped').

Raw Output:
{"message": "[Google.Passive] In general, use active voice instead of passive voice ('is skipped').", "location": {"path": "content/docs/for-platform-operators/concepts/lifecycle/analyze.md", "range": {"start": {"line": 18, "column": 240}}}, "severity": "INFO"}

The `lifecycle` must write [analysis metadata][analyzedtoml-toml] to `<analyzed>`, where:

Expand Down
Loading
Loading