Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Build time and runtime images content to the Platform docs #770

Merged
merged 8 commits into from
Oct 22, 2024
Merged

Adds Build time and runtime images content to the Platform docs #770

merged 8 commits into from
Oct 22, 2024

Conversation

hyounes4560
Copy link
Contributor

  • adds build and run images content under the platform section

@hyounes4560
adds build and run image content
bcee684 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560 hyounes4560 requested a review from a team as a code owner September 28, 2024 17:29
@hyounes4560
fixes a broken link
c127bac 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
AidanDelaney
AidanDelaney requested changes Oct 2, 2024
View reviewed changes
Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly questions about terminology.

content/docs/for-platform-operators/concepts/build-run-images.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/concepts/build-run-images.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/concepts/build-run-images.md Outdated Show resolved Hide resolved
content/docs/for-platform-operators/concepts/build-run-images.md Outdated Show resolved Hide resolved
@hyounes4560
renames the page and adds some feedback
18aa605 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560
uses runtime vs run image
c808d44 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560
adds reviewer feedback and updates page links
432d72f 
Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
@hyounes4560
Copy link
Contributor Author

updated based on @natalieparellano feedback; please take a look. FYI @AidanDelaney

AidanDelaney
AidanDelaney approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for #773 to fix the linting problem.

@AidanDelaney
Copy link
Member

Will fix the broken links (which are causing build filaure) later:

ERROR: found broken links:
target does not exist --- docs/for-platform-operators/concepts/builder/index.html --> /docs/for-platform-operators/concepts/base-images.md

@AidanDelaney AidanDelaney merged commit aaddb90 into buildpacks:main Oct 22, 2024
3 of 4 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 22, 2024
@AidanDelaney
Adds Build time and runtime images content to the Platform docs (#770)
f8ac091 
* adds build and run image content

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Aidan Delaney <aidan.delaney@gmail.com>

---------

Signed-off-by: Hanan Younes <hanan.algazaley@gmail.com>
Signed-off-by: Aidan Delaney <aidan.delaney@gmail.com>
Co-authored-by: Aidan Delaney <adelaney21@bloomberg.net>
Co-authored-by: Aidan Delaney <aidan.delaney@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AidanDelaney AidanDelaney AidanDelaney approved these changes

@natalieparellano natalieparellano natalieparellano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyounes4560 @AidanDelaney @natalieparellano