Added logging of bindings & fixed bindings bug #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pivotal-david-osullivan
force-pushed
the
binding_logging
branch
2 times, most recently
from
e3f30df
to
a27b023
Compare
dmikusa
approved these changes
Sep 23, 2021
|
For what it's worth, the driving factor behind this is that people really struggle with bindings. In many cases, users don't get the binding format correct, but the buildpack doesn't output anything in either case so it's not clear if a buildpack sees or does not see them. This makes debugging difficult. This change moves them front and center, so it's obvious when they're being read by a buildpack which makes debugging easier. |
pivotal-david-osullivan
force-pushed
the
binding_logging
branch
2 times, most recently
from
eec9540
to
a70681f
Compare
sambhav
previously approved these changes
Sep 23, 2021
sambhav
added
semver:minor
…gs from hidden files/dirs Signed-off-by: David O'Sullivan <davidos@vmware.com>
pivotal-david-osullivan
force-pushed
the
binding_logging
branch
from
2254126
to
afb92db
Compare
sambhav
reviewed
Sep 24, 2021
ekcasey
reviewed
Sep 24, 2021
|
Closing in favour of #79 which only fixes the bug mentioned in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where Bindings are silently created from hidden dirs. These were ignored when ConfigMap were being created but not for Bindings themselves.
This PR also logs bindings as pairs of 'name & keys' that are identified during the build, since it can be difficult to know whether bindings have been found as expected during the build process. It also prints a line to indicate if no bindings were identified, for the same reason.