Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detector acceptance #334

Merged
merged 7 commits into from
Aug 18, 2020
Merged

Detector acceptance #334

merged 7 commits into from
Aug 18, 2020

Conversation

yaelharel
Copy link
Contributor

No description provided.

@yaelharel yaelharel force-pushed the detector-acceptance branch 3 times, most recently from 22b5d81 to fd230fa Compare July 10, 2020 21:10
acceptance/detector_test.go Outdated Show resolved Hide resolved
acceptance/detector_test.go Outdated Show resolved Hide resolved
acceptance/detector_test.go Outdated Show resolved Hide resolved
acceptance/testdata/detector/Dockerfile Outdated Show resolved Hide resolved
acceptance/detector_test.go Outdated Show resolved Hide resolved
acceptance/detector_test.go Outdated Show resolved Hide resolved
Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments!

acceptance/detector_test.go Outdated Show resolved Hide resolved
acceptance/detector_test.go Outdated Show resolved Hide resolved
acceptance/detector_test.go Outdated Show resolved Hide resolved
acceptance/detector_test.go Outdated Show resolved Hide resolved
acceptance/detector_test.go Outdated Show resolved Hide resolved
@yaelharel yaelharel force-pushed the detector-acceptance branch from fd230fa to a5dec6c Compare July 24, 2020 18:23
@yaelharel
Copy link
Contributor Author

yaelharel commented Jul 24, 2020

I didn't push any changes yet. Just updated my branch based on main.

Yael Harel added 2 commits August 10, 2020 14:49
Signed-off-by: Yael Harel <yharel@vmware.com>
Signed-off-by: Yael Harel <yharel@vmware.com>
@yaelharel yaelharel force-pushed the detector-acceptance branch from a5dec6c to a2767f2 Compare August 11, 2020 23:58
Signed-off-by: Yael Harel <yharel@vmware.com>
@yaelharel yaelharel force-pushed the detector-acceptance branch from 156e337 to c4b1a48 Compare August 12, 2020 00:06
Everything will be deleted even if the docker run command failed

Signed-off-by: Yael Harel <yharel@vmware.com>
@yaelharel yaelharel marked this pull request as ready for review August 12, 2020 13:24
@yaelharel yaelharel requested a review from a team as a code owner August 12, 2020 13:24
Copy link
Member

@natalieparellano natalieparellano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple comments and questions.

acceptance/analyzer_test.go Outdated Show resolved Hide resolved
acceptance/analyzer_test.go Outdated Show resolved Hide resolved
acceptance/detector_test.go Outdated Show resolved Hide resolved
acceptance/detector_test.go Show resolved Hide resolved
acceptance/detector_test.go Outdated Show resolved Hide resolved
acceptance/detector_test.go Show resolved Hide resolved
acceptance/detector_test.go Outdated Show resolved Hide resolved
acceptance/detector_test.go Show resolved Hide resolved
to one place for all of the analyzer acceptance tests

Signed-off-by: Yael Harel <yharel@vmware.com>
Copy link
Member

@ekcasey ekcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I left a few (mostly cosmetic) suggestions

acceptance/detector_test.go Show resolved Hide resolved
acceptance/detector_test.go Outdated Show resolved Hide resolved
acceptance/detector_test.go Show resolved Hide resolved
acceptance/detector_test.go Outdated Show resolved Hide resolved
Signed-off-by: Yael Harel <yharel@vmware.com>
@yaelharel yaelharel requested a review from ekcasey August 17, 2020 23:50
acceptance/detector_test.go Outdated Show resolved Hide resolved
acceptance/detector_test.go Outdated Show resolved Hide resolved
Signed-off-by: Yael Harel <yharel@vmware.com>
@ekcasey ekcasey merged commit 27fe925 into buildpacks:main Aug 18, 2020
@ekcasey ekcasey linked an issue Aug 18, 2020 that may be closed by this pull request
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add acceptance tests
3 participants