-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detector acceptance #334
Detector acceptance #334
Conversation
22b5d81
to
fd230fa
Compare
...tdata/detector/container/cnb/buildpacks/simple_buildpack/simple_buildpack_version/bin/detect
Outdated
Show resolved
Hide resolved
acceptance/testdata/detector/container/custom_workspace/mock_app/run
Outdated
Show resolved
Hide resolved
acceptance/testdata/detector/container/custom_workspace/mock_app/run
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments!
fd230fa
to
a5dec6c
Compare
I didn't push any changes yet. Just updated my branch based on main. |
Signed-off-by: Yael Harel <yharel@vmware.com>
Signed-off-by: Yael Harel <yharel@vmware.com>
a5dec6c
to
a2767f2
Compare
Signed-off-by: Yael Harel <yharel@vmware.com>
156e337
to
c4b1a48
Compare
Everything will be deleted even if the docker run command failed Signed-off-by: Yael Harel <yharel@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple comments and questions.
to one place for all of the analyzer acceptance tests Signed-off-by: Yael Harel <yharel@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I left a few (mostly cosmetic) suggestions
...tdata/detector/container/cnb/buildpacks/simple_buildpack/simple_buildpack_version/bin/detect
Outdated
Show resolved
Hide resolved
Signed-off-by: Yael Harel <yharel@vmware.com>
Signed-off-by: Yael Harel <yharel@vmware.com>
No description provided.