Make lifecycle.toml backwards compatible #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameyer-pivotal
approved these changes
Aug 5, 2020
ekcasey
force-pushed
the
backwards-compatible-descriptor
branch
from
72c9404 to
9bef2c3
Compare
ameyer-pivotal
approved these changes
Aug 5, 2020
Signed-off-by: Emily Casey <ecasey@vmware.com>
ekcasey
force-pushed
the
backwards-compatible-descriptor
branch
from
9bef2c3 to
56f89ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We said this likely wasn't necessary in (RFC-0049)[https://github.com/buildpacks/rfcs/blob/main/text/0049-multi-api-lifecycle-descriptor.md#backwards-compatibility]
But... after seeing how
packfails when provided the new format (an NPE) I think makinglifecycle.tomlbackwards compatible is probably the right call.