Fixes analyzer acceptance tests for Windows #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahyoung
force-pushed
the
fix/analyzer-acceptance-windows
branch
5 times, most recently
from
63b4a99
to
922b711
Compare
micahyoung
changed the title
micahyoung
force-pushed
the
fix/analyzer-acceptance-windows
branch
from
922b711
to
1f04205
Compare
This was referenced Mar 8, 2021
micahyoung
force-pushed
the
fix/analyzer-acceptance-windows
branch
2 times, most recently
from
225d965
to
3961d4b
Compare
acceptance/analyzer_test.go
Outdated
| "--build-arg", "metadata="+metadata, | ||
| ) | ||
|
|
||
| noAuthRegCacheImage = noAuthRegistry.RepoName(cacheImageName) |
There was a problem hiding this comment.
I found myself scratching my head wondering "when do we push this image" but now I understand (I think) this works because we're using the shared storage volume. I feel like we might want to document this in a comment somewhere...
|
@micahyoung it's awesome to see this! I added a couple nits / comments on clarity but overall this is looking great! |
micahyoung
force-pushed
the
fix/analyzer-acceptance-windows
branch
from
3961d4b
to
3c7077a
Compare
Signed-off-by: Micah Young <ymicah@vmware.com>
- Fixes cache images create with wrong format - imgutil WithPlatform initializes OS-specific images - Windows sim base layers are generated by imgutil instead of lifecycle Signed-off-by: Micah Young <ymicah@vmware.com>
Co-authored-by: Natalie Arellano <narellano@vmware.com> Signed-off-by: Micah Young <ymicah@vmware.com>
- Use dual registries with shared data volume to test no-auth registries Signed-off-by: Micah Young <ymicah@vmware.com>
- Generated layers are handled by imgutil Signed-off-by: Micah Young <ymicah@vmware.com>
Signed-off-by: Micah Young <ymicah@vmware.com>
* Changes test helper signature to group related args * Adds GHA step to add insecure-registries entry * Test helpers will use the field to determine registry host * Changes to use imgutil for authorized/readonly registries Signed-off-by: Micah Young <ymicah@vmware.com>
Signed-off-by: Micah Young <ymicah@vmware.com>
micahyoung
force-pushed
the
fix/analyzer-acceptance-windows
branch
from
3c7077a
to
6bd40a9
Compare
Signed-off-by: Micah Young <ymicah@vmware.com>
micahyoung
force-pushed
the
fix/analyzer-acceptance-windows
branch
from
c90c25e
to
f8d9838
Compare
micahyoung
force-pushed
the
fix/analyzer-acceptance-windows
branch
2 times, most recently
from
117ad0e
to
f8d9838
Compare
|
Looks like this Docker engine issue was biting us (usage here). I'll have to check again but I'm hoping runner's docker CLI got bumped (or will shortly) and this should get back to green. |
micahyoung
force-pushed
the
fix/analyzer-acceptance-windows
branch
2 times, most recently
from
298484b
to
eca480b
Compare
added 2 commits
March 22, 2021 09:55
Signed-off-by: Micah Young <ymicah@vmware.com>
Signed-off-by: Micah Young <ymicah@vmware.com>
micahyoung
force-pushed
the
fix/analyzer-acceptance-windows
branch
from
eca480b
to
1e588b8
Compare
Signed-off-by: Micah Young <ymicah@vmware.com>
micahyoung
force-pushed
the
fix/analyzer-acceptance-windows
branch
from
8f8c180
to
e033d1c
Compare
micahyoung
commented
Mar 23, 2021
micahyoung
commented
Mar 23, 2021
Signed-off-by: Micah Young <ymicah@vmware.com> Co-authored-by: Natalie Arellano <narellano@vmware.com>
micahyoung
commented
Mar 23, 2021
| func SeedDockerVolume(t *testing.T, srcPath string) string { | ||
| volumeName := "test-volume-" + RandString(10) | ||
| containerName := "test-volume-helper-" + RandString(10) | ||
| volumeHelperImage := "alpine" |
There was a problem hiding this comment.
Since this helper can only be used on Linux, I made the image name local. Eventually, when Windows implements this functionality, this function will also be ported.
added 3 commits
March 25, 2021 09:34
Signed-off-by: Micah Young <ymicah@vmware.com>
Signed-off-by: Micah Young <ymicah@vmware.com>
micahyoung
force-pushed
the
fix/analyzer-acceptance-windows
branch
from
7c794c4
to
b5c226c
Compare
added 2 commits
March 25, 2021 10:52
- Unknown integrity of docker-cli-builder binary: StefanScherer/docker-cli-builder#13 Signed-off-by: Micah Young <ymicah@vmware.com>
- Already present on runner Signed-off-by: Micah Young <ymicah@vmware.com>
micahyoung
force-pushed
the
fix/analyzer-acceptance-windows
branch
from
b5c226c
to
3f09d11
Compare
added 2 commits
March 25, 2021 11:16
micahyoung
force-pushed
the
fix/analyzer-acceptance-windows
branch
from
bbc5b45
to
072b3d5
Compare
This helper simplifies running tests against remote Windows daemon from a Unix workstation - Updates docker cli to 20.10.5 - Adds richgo, docker build compression Signed-off-by: Micah Young <ymicah@vmware.com>
natalieparellano
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables almost all the analyzer acceptance tests for Windows. This does not yet fix other acceptance tests for Windows, as this is intended to introduce the patterns those tests follow in later commits.
In general, uses tests helpers and variables for OS differences. Existing helpers workaround the following limitations on windows: