Skip to content

Commit

Permalink
Merge pull request #2166 from buildpacks/chore/fix-macos-binaries
Browse files Browse the repository at this point in the history
Building darwin arm64 binaries by default on CI and amd64 during releases
  • Loading branch information
jjbustamante authored May 24, 2024
2 parents f56bca5 + e792c69 commit b8f5fc8
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ jobs:
config: [macos, linux, windows-lcow, windows-wcow]
include:
- config: macos
os: macos
# since macos-14 the latest runner is arm64
os: macos-arm64
runner: macos-latest
no_docker: "true"
pack_bin: pack
Expand Down Expand Up @@ -170,8 +171,9 @@ jobs:
- name: linux-arm64
goarch: arm64
goos: linux
- name: macos-arm64
goarch: arm64
- name: macos
# since macos-14 default runner is arm, we need to build for intel architecture later
goarch: amd64
goos: darwin
- name: linux-s390x
goarch: s390x
Expand Down

1 comment on commit b8f5fc8

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Go Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: b8f5fc8 Previous: f56bca5 Ratio
BenchmarkBuild/with_Trusted_Builder 2516214173 ns/op 1073162337 ns/op 2.34

This comment was automatically generated by workflow using github-action-benchmark.

CC: @buildpacks/platform-maintainers

Please sign in to comment.