Fixed version of the linter to 1.51.1 #1843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Domenico Luciani <dluciani@vmware.com>
github-actions
bot
removed
the
type/chore
|
Tests are failing due to moby/moby#45935 |
Yeah @joe-kimmel-vmw was working on that, how did we fix it? |
github-actions
bot
removed
the
type/chore
jkutner
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that on Lifecycle we are using a fixed version of the linter but on Pack we are using the latest one.
It can be risky having always the latest version (introduction of bugs and breaking changes)
So to have it aligned I added the fixed version on Pack Makefile
Output
Before
Whenever we download the linter we install the latest version
After
Now whenever we download the linter we install version 1.51.1
Documentation
Related
Resolves #___