Removing experimental configuration for extensions starting with API 0.13 #2125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds some logic to determine when the experimental mode must be enable when running extensions. Since Platform API 0.13, extensions are no more experimental and pack doesn't need to set the env variable
CNB_EXPERIMENTAL_MODE=warn
, With this PR pack will evaluate if the API version is less than 0.13 and in such as case it will add the environment variableOutput
Before
Pack enables experimental mode when running against lifecycle < 0.18.x
After
When running with platform API <= 0.12
===> EXTENDING (BUILD) Running the extender on OS linux from image pack.local/builder/6463666b7974676b7763:latest with: Container Settings: Args: /cnb/lifecycle/extender -app /workspace -log-level debug System Envs: CNB_EXPERIMENTAL_MODE=warn CNB_PLATFORM_API=0.12
When running with platform API >= 0.13 the
CNB_EXPERIMENTAL_MODE=warn
env is not set===> EXTENDING (BUILD) Running the extender on OS linux from image pack.local/builder/6e647a67686d6278736d:latest with: Container Settings: Args: /cnb/lifecycle/extender -app /workspace -log-level debug System Envs: CNB_PLATFORM_API=0.13
Documentation
Related
Resolves #2066