-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating to Docker 26.x & lifecycle 0.19.4 #2136
Conversation
Signed-off-by: Juan Bustamante <bustamantejj@gmail.com>
06ef755
to
58fd4be
Compare
Signed-off-by: Juan Bustamante <bustamantejj@gmail.com> Signed-off-by: Natalie Arellano <narellano@vmware.com>
58fd4be
to
0daa11f
Compare
…n was broken in darwin. Thanks Matej Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2136 +/- ##
==========================================
+ Coverage 70.15% 70.19% +0.04%
==========================================
Files 231 233 +2
Lines 17227 17259 +32
==========================================
+ Hits 12084 12113 +29
- Misses 4360 4362 +2
- Partials 783 784 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
darwin. This is important because docker 26 did a refactoring and safepath.Join is not available for darwin. This is a workaround for now Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
81c53e9
to
3c6dc12
Compare
Signed-off-by: Juan Bustamante <juan.bustamante@broadcom.com>
Signed-off-by: Juan Bustamante <jbustamante@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good @jjbustamante. We'll work on getting a lifecycle release out soon so that you can update to that version in go.mod
Signed-off-by: Natalie Arellano <narellano@vmware.com>
@jjbustamante I pushed 7cd4e0b to bring the lifecycle up to a released version. When CI goes green we should be good to merge :) |
Summary
With docker 26.0.0 some refactoring was done and the parsing logic for volumes is not available on
darwin
, as a consequence pack failed to compile on mac machines. See this discussion created for more details.This PR in addition to update the dependencies to docker 26.0.0 also reimplement the
processVolumes
method fordarwin
os.Output
Before
when compiling pack after updating the dependencies to docker 26.0.0
After
The code compiles and the unit tests are passing
Documentation
Related
Resolves #___