Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the pack build warn that the positional argument will not be treated as the source directory path #2256

Merged
merged 8 commits into from
Oct 25, 2024
Merged

Make the pack build warn that the positional argument will not be treated as the source directory path #2256

merged 8 commits into from
Oct 25, 2024

Commits on Sep 2, 2024

  1. Make the 'pack build' command warn that the positional argument will … 

    …not be treated as the source directory path.

Signed-off-by: Hiroshi Hayakawa <hhiroshell@gmail.com>
    @hhiroshell
    hhiroshell committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    0a5cf9c View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Add a test case for when the 'pack build' is called with the '--path'… 

    … flag.

Signed-off-by: Hiroshi Hayakawa <hhiroshell@gmail.com>
    @hhiroshell
    hhiroshell committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    7066e52 View commit details
    Browse the repository at this point in the history

  2. Improve descriptions for some test cases. 

    Signed-off-by: Hiroshi Hayakawa <hhiroshell@gmail.com>
    @hhiroshell
    hhiroshell committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    66982d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Make it warns only when a local path with the same string as the spec… 

    …ified image name exists

Signed-off-by: Hiroshi Hayakawa <hhiroshell@gmail.com>
    @hhiroshell
    hhiroshell committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    cee65f2 View commit details
    Browse the repository at this point in the history

  2. rephrase the test description 

    Signed-off-by: Hiroshi Hayakawa <hhiroshell@gmail.com>
    @hhiroshell
    hhiroshell committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    59a0abf View commit details
    Browse the repository at this point in the history

  3. avoid using os.MkdirTemp() to prevent test failures on macOS 

    Signed-off-by: hhiroshell <hhiroshell@gmail.com>
    @hhiroshell
    hhiroshell committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    569e992 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Merge branch 'main' into fix-pack-2231

    @jjbustamante
    jjbustamante authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    98c32ed View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Use an existing directory instead of creating and deleting directorie… 

    …s for each '--path' flag case to ensure no temp directories are left behind in case of a test failure.

Signed-off-by: Hiroshi Hayakawa <hhiroshell@gmail.com>
    @hhiroshell
    hhiroshell committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3aee96e View commit details
    Browse the repository at this point in the history