Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Lifecycle Descriptor information in inspect-builder #269

Merged
merged 3 commits into from
Sep 6, 2019

Conversation

jromero
Copy link
Member

@jromero jromero commented Aug 27, 2019

  • Remove support for lifecycle < 0.3.0
  • Abstract buildpack and lifecycle contents into blobs
  • Remove use of image cache in favor of volume cache
  • Add option to change cache dir in pack.Client

Resolves #260

Signed-off-by: Javier Romero jromero@pivotal.io
Signed-off-by: Andrew Meyer ameyer@pivotal.io

blob/blob_test.go Outdated Show resolved Hide resolved
Copy link
Member

@sclevine sclevine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have as much context on this repo as @ekcasey, but here's some feedback :)

acceptance/acceptance_test.go Outdated Show resolved Hide resolved
acceptance/acceptance_test.go Outdated Show resolved Hide resolved
blob/blob.go Outdated Show resolved Hide resolved
blob/downloader.go Outdated Show resolved Hide resolved
@jromero jromero force-pushed the feature/260-lifecycle-descriptor branch 2 times, most recently from bfc66b8 to 17995be Compare August 28, 2019 17:35
blob/blob.go Show resolved Hide resolved
blob/blob.go Show resolved Hide resolved
blob/blob.go Show resolved Hide resolved
@ameyer-pivotal ameyer-pivotal force-pushed the feature/260-lifecycle-descriptor branch from 17995be to d5f3361 Compare August 29, 2019 19:17
@ameyer-pivotal ameyer-pivotal force-pushed the feature/260-lifecycle-descriptor branch from d5f3361 to 7a2f46c Compare August 29, 2019 19:20
blob/blob.go Outdated Show resolved Hide resolved
* Remove support for lifecycle < 0.3.0
* Abstract buildpack and lifecycle contents into `blobs`
* Remove use of image cache in favor of volume cache
* Add option to change cache dir in `pack.Client`

Signed-off-by: Javier Romero <jromero@pivotal.io>
Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
@ameyer-pivotal ameyer-pivotal force-pushed the feature/260-lifecycle-descriptor branch from 7a2f46c to aa6529d Compare August 29, 2019 19:29
blob/blob.go Outdated Show resolved Hide resolved
Signed-off-by: Javier Romero <jromero@pivotal.io>
@jromero jromero force-pushed the feature/260-lifecycle-descriptor branch from a527089 to ccafced Compare September 3, 2019 14:16
@jromero jromero dismissed sclevine’s stale review September 3, 2019 14:17

Changes applied

blob/blob.go Show resolved Hide resolved
build/build.go Show resolved Hide resolved
blob/blob.go Outdated Show resolved Hide resolved
@ameyer-pivotal ameyer-pivotal force-pushed the feature/260-lifecycle-descriptor branch from abd13e2 to d92e1c6 Compare September 4, 2019 20:46
Copy link
Member

@ekcasey ekcasey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some cleanup suggestions

acceptance/acceptance_test.go Outdated Show resolved Hide resolved
acceptance/acceptance_test.go Show resolved Hide resolved
api/version.go Outdated Show resolved Hide resolved
build.go Outdated Show resolved Hide resolved
build/phase_test.go Outdated Show resolved Hide resolved
commands/inspect_builder_test.go Outdated Show resolved Hide resolved
commands/inspect_builder_test.go Outdated Show resolved Hide resolved
image/fetcher_test.go Outdated Show resolved Hide resolved
image/fetcher_test.go Show resolved Hide resolved
build/build.go Show resolved Hide resolved
@jromero jromero dismissed sclevine’s stale review September 5, 2019 21:10

Issues resolved

- Plus minor refactor

Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
@jromero jromero force-pushed the feature/260-lifecycle-descriptor branch from d92e1c6 to ef9b4f2 Compare September 6, 2019 01:52
@jromero jromero merged commit 6dd456c into master Sep 6, 2019
@ekcasey ekcasey deleted the feature/260-lifecycle-descriptor branch October 29, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add lifecycle API metadata to builder
4 participants