-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Lifecycle Descriptor information in inspect-builder #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sclevine
previously requested changes
Aug 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have as much context on this repo as @ekcasey, but here's some feedback :)
jromero
force-pushed
the
feature/260-lifecycle-descriptor
branch
2 times, most recently
from
August 28, 2019 17:35
bfc66b8
to
17995be
Compare
sclevine
reviewed
Aug 29, 2019
sclevine
reviewed
Aug 29, 2019
sclevine
reviewed
Aug 29, 2019
ameyer-pivotal
force-pushed
the
feature/260-lifecycle-descriptor
branch
from
August 29, 2019 19:17
17995be
to
d5f3361
Compare
ameyer-pivotal
force-pushed
the
feature/260-lifecycle-descriptor
branch
from
August 29, 2019 19:20
d5f3361
to
7a2f46c
Compare
* Remove support for lifecycle < 0.3.0 * Abstract buildpack and lifecycle contents into `blobs` * Remove use of image cache in favor of volume cache * Add option to change cache dir in `pack.Client` Signed-off-by: Javier Romero <jromero@pivotal.io> Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
ameyer-pivotal
force-pushed
the
feature/260-lifecycle-descriptor
branch
from
August 29, 2019 19:29
7a2f46c
to
aa6529d
Compare
Signed-off-by: Javier Romero <jromero@pivotal.io>
jromero
force-pushed
the
feature/260-lifecycle-descriptor
branch
from
September 3, 2019 14:16
a527089
to
ccafced
Compare
sclevine
previously requested changes
Sep 3, 2019
ameyer-pivotal
force-pushed
the
feature/260-lifecycle-descriptor
branch
from
September 4, 2019 20:46
abd13e2
to
d92e1c6
Compare
ameyer-pivotal
approved these changes
Sep 4, 2019
ekcasey
approved these changes
Sep 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some cleanup suggestions
- Plus minor refactor Signed-off-by: Andrew Meyer <ameyer@pivotal.io>
jromero
force-pushed
the
feature/260-lifecycle-descriptor
branch
from
September 6, 2019 01:52
d92e1c6
to
ef9b4f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
blobs
pack.Client
Resolves #260
Signed-off-by: Javier Romero jromero@pivotal.io
Signed-off-by: Andrew Meyer ameyer@pivotal.io