-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Sub Team Maintainer (formerly author) Creates Repo Issues #106
Conversation
Signed-off-by: David Freilich <dfreilich@vmware.com>
I think this makes a lot of sense if the RFC comes from a contributor/core team member, but I've noticed in the prior art that none of the other RFC processes follow this practice. I wonder if it this instead should fall upon the subteam to manage/create issues when they're finalized maybe in the subteam/maintainers meeting once a week to go over finalized RFCs. This requires a lot more onus on the RFC author especially if they are a non-contributor. |
@hone I definitely hear that. A suggestion that came up in conversation (I believe from @natalieparellano) was to add a section like
to the RFC template, where the author of the PR would write what repos/issues they would create, which could then get approval from the reviewers, as well as additional suggestions. To lower the barrier of entry, I would add that while we welcome well-fleshed out issues, even placeholder ones that link to the RFC are a better start than no issues. |
Signed-off-by: David Freilich <dfreilich@vmware.com>
text/0000-create-repo-issues.md
Outdated
|
||
# How it Works | ||
[how-it-works]: #how-it-works | ||
When a PR has been accepted (after FCP has concluded), the sub-team maintainers make issues (tagging the RFC PR) in the relevant buildpack repos, and labels the PR `issues-created`. At that point, the RFC PR may be merged in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that some sub-teams have multiple maintainers, there may still be some potential for ambiguity around who will handle a particular RFC. I propose that when we move RFCs into FCP we should assign a sub-team maintainer to the PR and they will be responsible for creating the issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ekcasey my thought is that this would happen during the weekly subteam meetings, but I don't feel strongly about it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some RFCs that require multiple sub-teams to create issues from a single RFC. For the sake of minimizing coordination could we maybe change this to be a label per subteam.
For example:
issues-created/platform
issues-created/implementation
If no issues need to be created for a given subteam they can add that label for brevity sake. We can further automate this process by checking that these labels are present.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I incorporated @jromero's feedback. LMK what you think.
Signed-off-by: David Freilich <dfreilich@vmware.com>
Signed-off-by: David Freilich <dfreilich@vmware.com>
Signed-off-by: David Freilich <dfreilich@vmware.com>
Once this RFC is merged in that means someone from the core team will need to create the issue on this repo. :) |
Final Comment Period with merge disposition, closing on 30 September, 2020. |
Signed-off-by: David Freilich <dfreilich@vmware.com> Co-authored-by: Javier Romero <root@jromero.codes>
Readable
Signed-off-by: David Freilich dfreilich@vmware.com