RFC: Any-stack Buildpacks #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
sclevine
force-pushed
the
any-stack-buildpacks
branch
from
d66fc58 to
31bfc43
Compare
ekcasey
approved these changes
Jul 28, 2020
nebhale
approved these changes
Jul 28, 2020
hone
reviewed
Aug 5, 2020
text/0000-any-stack-buildpacks.md
Outdated
| # Alternatives | ||
| [alternatives]: #alternatives | ||
|
|
||
| - We could add a special field that indicates any-stack compatibility, so that buildpack authors need to explicitly opt-in to the new behavior. This would prevent buildpack authors who don't know about stacks from inadvertently declaring any-stack compatibility without adequate testing. |
There was a problem hiding this comment.
This seems like a good compromise. WRT platforms, maybe we just claim a set of stack ids for all, linux, windows? I'm not married to any of those names.
There was a problem hiding this comment.
Jumping on this bandwagon - if it could harm the UX, I'd rather it be gated/you have to opt in, so that buildpack authors don't ruin users trust in the platform.
|
This is a good addition since I do think many buildpacks can be built to be more generic. I share Ben's concerns of it being the default and would like to see us explore the opt-in options. |
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
|
Switched to opt-in, ready for review. |
nebhale
approved these changes
Aug 11, 2020
jkutner
approved these changes
Aug 12, 2020
dfreilich
approved these changes
Aug 12, 2020
hone
reviewed
Aug 12, 2020
hone
approved these changes
Aug 12, 2020
|
Final Comment Period with merge disposition, closing on 19 August, 2020. |
Signed-off-by: Stephen Levine <stephen.levine@gmail.com> Co-authored-by: Ben Hale <bhale@vmware.com>
Signed-off-by: Stephen Levine <stephen.levine@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Readable