Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More exit code definition #115

Merged
merged 2 commits into from
Jul 27, 2020
Merged

More exit code definition #115

merged 2 commits into from
Jul 27, 2020

Conversation

ekcasey
Copy link
Member

@ekcasey ekcasey commented Jul 23, 2020

  • Defines specific error codes for API incompatibilities
  • Don't use the same codes for detect and build errors, to avoid ambiguity when using creator
  • Error code ranges indicate phase - useful for consumers of creator

I am happy to take the phase specific ranges out if it is controversial but I think the first two bullet points above are important changes to get into platform 0.4.

@ekcasey ekcasey requested a review from a team as a code owner July 23, 2020 19:38
@nebhale nebhale requested a review from a team July 23, 2020 20:01
@ekcasey ekcasey added this to the Platform 0.4 milestone Jul 23, 2020
platform.md Show resolved Hide resolved
* Defines specific error codes for API incompatibilities
* Dont use the same codes for detect and build errors, to avoid ambiguity when using creator
* Error code ranges indicate phase - useful for consumers of creator

Signed-off-by: Emily Casey <ecasey@vmware.com>
@nebhale nebhale requested a review from a team July 27, 2020 15:52
@nebhale nebhale merged commit b76ce13 into platform/0.4 Jul 27, 2020
@nebhale nebhale deleted the exit-codes branch July 27, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants