RFC 0045: handling of args in direct=false processes #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
yaelharel
reviewed
Jul 23, 2020
buildpack.md
Outdated
| @@ -556,7 +556,10 @@ To choose an execution strategy, | |||
|
|
|||
| 1. **IF** a buildpack-provided process type is chosen as the start command, | |||
| 1. **IF** the process type does not have `direct` set to `true`, | |||
There was a problem hiding this comment.
Maybe it's better to write
**IF** the process type has `direct` set to `false`
| **THEN** the lifecycle MUST invoke the value of `command` as a command using Bash with values of `args` provided as arguments. | ||
| 1. **IF** the process has one or more `args` | ||
| **THEN** the lifecycle MUST invoke a command using Bash, where `command` and each entry in `args` are shell-parsed tokens in the command. | ||
| 2. **IF** the process has zero `args` |
There was a problem hiding this comment.
What do you think about changing 1 + 2 to if - else?
I'm not sure what is more clear.
There was a problem hiding this comment.
I wanted to insert this change without changing the conventions in this part of the spec. The existing convention here is numbered IFs.
jkutner
approved these changes
Jul 24, 2020
Signed-off-by: Emily Casey <ecasey@vmware.com>
nebhale
approved these changes
Jul 27, 2020
sclevine
approved these changes
Jul 27, 2020
ekcasey
added a commit
that referenced
this pull request
Jul 28, 2020
Now that we have buidpack API dependent launch logic, the launcher needs the api of each buildpack to exist in metadata.toml so it can do the right thing * See #116 for an example (arg parsing for direct=false processes) Other phases may have buidpack API dependent logic as well. Adding the `api` to group.toml will provide this the api of each buildpack everywhere it is needed. Signed-off-by: Emily Casey <ecasey@vmware.com>
This was referenced Jul 28, 2020
ekcasey
added a commit
that referenced
this pull request
Jul 30, 2020
Now that we have buidpack API dependent launch logic, the launcher needs the api of each buildpack to exist in metadata.toml so it can do the right thing * See #116 for an example (arg parsing for direct=false processes) Other phases may have buidpack API dependent logic as well. Adding the `api` to group.toml will provide this the api of each buildpack everywhere it is needed. Signed-off-by: Emily Casey <ecasey@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.