Clarify stack concepts #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously stack ID requirements including: * allowed characters * global uniqueness were only specified in the buildpack spec, in the buildpack.toml data formt section. This PR moves stack ID description and requirements in the Platform spec with the rest of the stack concepts. Clarifies stack concepts, incorporating feedback that surfaced in previous PR reviews #87 (comment). Signed-off-by: Emily Casey <ecasey@vmware.com>
ekcasey
requested review from
hone,
jabrown85,
jkutner,
natalieparellano,
nebhale,
sclevine and
yaelharel
ekcasey
added a commit
that referenced
this pull request
Oct 16, 2020
Stack ID requirements have been removed from the buildpack API specification. PR #154 moves these requirements to the platform specification with the other stack requirements. Signed-off-by: Emily Casey <ecasey@vmware.com>
Merged
jabrown85
approved these changes
Oct 19, 2020
nebhale
approved these changes
Oct 19, 2020
hone
approved these changes
Oct 20, 2020
jkutner
reviewed
Oct 21, 2020
jkutner
approved these changes
Oct 21, 2020
ekcasey
added a commit
that referenced
this pull request
Oct 21, 2020
Stack ID requirements have been removed from the buildpack API specification. PR #154 moves these requirements to the platform specification with the other stack requirements. Signed-off-by: Emily Casey <ecasey@vmware.com>
sclevine
approved these changes
Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously stack ID requirements including:
were only specified in the buildpack spec, in the buildpack.toml data formt section. This PR moves stack ID description and requirements in the Platform spec with the rest of the stack concepts.
Clarifies stack concepts, incorporating feedback that surfaced in previous PR reviews #87 (comment).
Signed-off-by: Emily Casey ecasey@vmware.com