Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base image prompts should ask for which deps to add based on project type #89

Closed
dr-housemd opened this issue Jul 17, 2024 · 2 comments · Fixed by #95
Closed

base image prompts should ask for which deps to add based on project type #89

dr-housemd opened this issue Jul 17, 2024 · 2 comments · Fixed by #95
Assignees
Labels
good first issue Good for newcomers
Milestone

Comments

@dr-housemd
Copy link
Contributor

When a user does a bsf init in a Go repo and they've opted-in for creating a base image, we should ask them -

"Would you like to add common Go dependencies(compiler, linter, debugger, etc)?(Y/n)"

If they say yes, we should add them to bsf.hcl.
Similar for other languages.

We already have the common dependencies listed here-

goDevDeps := append(commonDevDeps, "go@1.22.3", "gotools@0.18.0", "delve@1.22.1")

We just need to avoid generating the App modules when user has selected base image.

@dr-housemd dr-housemd added the good first issue Good for newcomers label Jul 17, 2024
@dr-housemd dr-housemd added this to the v0.3.0 milestone Jul 17, 2024
@utsab818
Copy link
Contributor

Hey, I would love to try out this issue.
Would you please guide me by providing more information about this?

@dr-housemd
Copy link
Contributor Author

Hey @utsab818 , I've assigned the issue to you. Feel free to start a thread over at discord if you have any questions or need help with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants