Added common dependencies #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utsab818
force-pushed
the
addcommondependencies
branch
from
fce8f8c
to
c716f18
Compare
rakshitgondwal
requested changes
Aug 1, 2024
There was a problem hiding this comment.
Hi @utsab818, Thank you for this PR.
The generatehcl2NixConf and WriteConfig should not be in init/init.go.
We are already doing these under init/model.go.
Please have a look at how we are passing the values over to the model file and generate common dependencies using that.
utsab818
force-pushed
the
addcommondependencies
branch
from
c716f18
to
90c6f7a
Compare
|
@rakshitgondwal Please check this. I checked it for my go project and it seems to be working fine. |
utsab818
force-pushed
the
addcommondependencies
branch
from
90c6f7a
to
6bfccbe
Compare
utsab818
force-pushed
the
addcommondependencies
branch
from
dab5874
to
3cc9c40
Compare
Signed-off-by: utsab818 <utsabsapkota4231@gmail.com>
utsab818
force-pushed
the
addcommondependencies
branch
from
61d50cf
to
247a0ac
Compare
Signed-off-by: utsab818 <utsabsapkota4231@gmail.com>
rakshitgondwal
approved these changes
Aug 3, 2024
|
Thank you for your contribution @utsab818! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89