feat: add --check flag to the update command
#49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hanshal101, Thank you for the PR. Can you please sign off your commits? |
hanshal101
force-pushed
the
bsf-update-check
branch
3 times, most recently
from
8bb71f6
to
1543488
Compare
|
also, can you please add yourself to CONTRIBUTORS file as mentioned here? |
Signed-off-by: hanshal101 <82961842+hanshal101@users.noreply.github.com>
Signed-off-by: hanshal101 <82961842+hanshal101@users.noreply.github.com>
hanshal101
force-pushed
the
bsf-update-check
branch
2 times, most recently
from
dfdef8e
to
26a1222
Compare
dr-housemd
reviewed
Jul 3, 2024
Signed-off-by: hanshal101 <82961842+hanshal101@users.noreply.github.com>
hanshal101
force-pushed
the
bsf-update-check
branch
from
26a1222
to
2ffee94
Compare
Signed-off-by: hanshal101 <82961842+hanshal101@users.noreply.github.com>
dr-housemd
reviewed
Jul 3, 2024
Signed-off-by: hanshal101 <82961842+hanshal101@users.noreply.github.com>
dr-housemd
reviewed
Jul 3, 2024
Signed-off-by: hanshal101 <82961842+hanshal101@users.noreply.github.com>
dr-housemd
reviewed
Jul 3, 2024
Signed-off-by: hanshal101 <82961842+hanshal101@users.noreply.github.com>
dr-housemd
reviewed
Jul 3, 2024
dr-housemd
reviewed
Jul 3, 2024
Signed-off-by: hanshal101 <82961842+hanshal101@users.noreply.github.com>
dr-housemd
reviewed
Jul 3, 2024
Signed-off-by: hanshal101 <82961842+hanshal101@users.noreply.github.com>
Signed-off-by: hanshal101 <82961842+hanshal101@users.noreply.github.com>
dr-housemd
reviewed
Jul 3, 2024
Signed-off-by: hanshal101 <82961842+hanshal101@users.noreply.github.com>
dr-housemd
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
LGTM.
Thanks @hanshal101 for this PR ,your patience with the review and quick response!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSES #48
FIXES #48
Description
This PR adds the functionality to check for updates before updating them through
--checkflag.