add --digest flag #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dr-housemd
reviewed
Jul 20, 2024
pkg/oci/skopeo.go
Outdated
| return err | ||
| } | ||
|
|
||
| fmt.Println("Digest:", digest) |
There was a problem hiding this comment.
we shouldn't print out in pkg/
dr-housemd
reviewed
Jul 20, 2024
Horiodino
force-pushed
the
digest
branch
2 times, most recently
from
02c1a06
to
13ab9f1
Compare
dr-housemd
reviewed
Aug 3, 2024
cmd/oci/oci.go
Outdated
| @@ -38,6 +38,8 @@ func init() { | |||
| OCICmd.Flags().BoolVarP(&dfSwap, "df-swap", "", false, "Modify base images in Dockerfile") | |||
| OCICmd.Flags().StringVarP(&tag, "tag", "t", "", "The tag that will be replaced with original tag in Dockerfile") | |||
| OCICmd.Flags().StringVar(&path, "path", "", "The path to Dockerfile") | |||
| OCICmd.Flags().BoolVar(&digest, "digest", false, "Get the digest of the image") | |||
| OCICmd.Flags().StringVar(&auth, "auth", "", "The auth to use to authenticate to the registry") | |||
There was a problem hiding this comment.
Let's use the same flag name as skopeo for now so this should be dest-creds.
Also, please add an example on how to use it in the Long section(for both auth and digest).
dr-housemd
reviewed
Aug 3, 2024
pkg/oci/skopeo.go
Outdated
| func Push(dir, imageName string, digest bool, auth string) error { | ||
| var cmd *exec.Cmd | ||
| if digest { | ||
| cmd = exec.Command("skopeo", "copy", "--insecure-policy", "dir:"+dir, "docker://"+imageName+"@@unknown-digest@@", "--digestfile=bsf-result/digest", "--dest-creds", auth) |
There was a problem hiding this comment.
We can't rely on the directory name being bsf-result. It is configurable by the user.
There was a problem hiding this comment.
Can we use dir argument somehow?
dr-housemd
reviewed
Aug 3, 2024
cmd/oci/oci.go
Outdated
| @@ -47,6 +49,7 @@ var OCICmd = &cobra.Command{ | |||
| Long: ` | |||
| bsf oci <artifact> | |||
| bsf oci <artifact> --platform <platform> | |||
| bsf oci <artifact> --push --dest-creds user:password | |||
There was a problem hiding this comment.
One more example for digest flag.
dr-housemd
reviewed
Aug 3, 2024
pkg/oci/skopeo.go
Outdated
| cmd := exec.Command("nix", "run", "nixpkgs#skopeo", "--", "copy", "--insecure-policy", "dir:"+dir, "docker://"+imageName) | ||
| func Push(dir, imageName string, digest bool, destcreds string) error { | ||
| var cmd *exec.Cmd | ||
| digestPath := strings.Split(dir, "/")[0] + "/digest" |
There was a problem hiding this comment.
can we get the digestPath as an argument? If empty, we do not push by digest.
Horiodino
force-pushed
the
digest
branch
2 times, most recently
from
c772791
to
a7b6f13
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue : #39
uses
bsf oci --push --digest --auth=username:password