Skip to content

Commit

Permalink
Makefile: inject Git version to main program
Browse files Browse the repository at this point in the history
Silly mistake: I forgot to inject Git version to main program on build;
thus, everyone running v1.1.0 got "Vanadia version: HEAD" when running
`./vanadia -v`.
  • Loading branch information
saifulwebid committed Nov 8, 2017
1 parent 0a826d0 commit 4d3f5ee
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
vanadia: main.go blueprint/drafter.go blueprint/* postman/* config/* vendor/*
@go build -o vanadia
@go build -ldflags "-X main.version=${TRAVIS_TAG}" -o vanadia

clean:
rm -f vanadia
Expand Down
3 changes: 2 additions & 1 deletion main.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ const (
defaultConfigFileName = "vanadia.yml"
)

var version string

func main() {
var (
inFileName = flag.String("input", "", "Location of .apib file as input.")
Expand All @@ -26,7 +28,6 @@ func main() {
inFileByte []byte
outFile *os.File
err error
version string
)

// Short version for version (pun non intended)
Expand Down

0 comments on commit 4d3f5ee

Please sign in to comment.