Add icon to readme and favicon to generated code #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice! LGTM |
christoph-jerolimov
force-pushed
the
icon
branch
from
5a08cef to
ed0eb08
Compare
bumi
requested changes
Nov 22, 2021
| @@ -111,6 +111,7 @@ | |||
| cursor: pointer; | |||
| } | |||
| </style> | |||
| <link rel="icon" type="image/svg+xml" href="/lnme/favicon.svg" /> | |||
There was a problem hiding this comment.
👍 we should use that also as og:image further up in line 9
There was a problem hiding this comment.
Updated, removed the zap.svg and rebuild the generated code with rice
There was a problem hiding this comment.
should we use the full lnme-icon as og:image ?
in Alby for example:
vs.
christoph-jerolimov
force-pushed
the
icon
branch
from
ed0eb08 to
780f237
Compare
christoph-jerolimov
force-pushed
the
icon
branch
from
780f237 to
cffdded
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28 :)
After merging the readme looks like this: