Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avif-integration need a 16KB version for Android #5433

Closed
xuetaotao-lotusflare opened this issue Jul 24, 2024 · 4 comments · Fixed by #5465
Closed

avif-integration need a 16KB version for Android #5433

xuetaotao-lotusflare opened this issue Jul 24, 2024 · 4 comments · Fixed by #5465

Comments

@xuetaotao-lotusflare
Copy link

Glide Version: 4.16.0

Integration libraries: avif-integration: 4.16.0

Device/Android Version: Virtual Device Pixel 8, Android 15, Page Size 16KB

Issue details / Repro steps / Use case background: App crashes when opened.

Glide load line / GlideModule (if any) / list Adapter code (if any):

Glide.with...

Layout XML:

<FrameLayout xmlns:android="...

Stack trace / LogCat:

Fatal signal 11 (SIGSEGV), code 2 (SEGV_ACCERR), fault addr 0x785f57d5a950 in tid 17964 (glide-disk-cach), pid 17824 (.mobile.android)
pid: 17824, tid: 17964, name: glide-disk-cach
 #00 pc 0000000000002950  /data/app/~~quB3bSKEfTjbXrxK_m9H8Q==/com.android-m-RaB9E7J0P3PgPP8wsTXA==/base.apk (offset 0x4f08000)
#01 pc 00000000000c6694  /data/app/~~quB3bSKEfTjbXrxK_m9H8Q==/com.android-m-RaB9E7J0P3PgPP8wsTXA==/base.apk!libavif_android.so (offset 0x4e40000) 
#18 pc 000000000037e588  /data/app/~~quB3bSKEfTjbXrxK_m9H8Q==/com.android-m-RaB9E7J0P3PgPP8wsTXA==/base.apk (org.aomedia.avif.android.AvifDecoder.<clinit>+0)
#27 pc 00000000003f0c58  /data/app/~~quB3bSKEfTjbXrxK_m9H8Q==/com.android-m-RaB9E7J0P3PgPP8wsTXA==/base.apk (com.bumptech.glide.integration.avif.AvifByteBufferBitmapDecoder.handles+0)
<img width="1220" alt="image" src="https://github.com/user-attachments/assets/e8c2a296-e847-47df-92a0-812590419b87">
@xuetaotao-lotusflare
Copy link
Author

Can use this aar package and combine it with the three classes under glide's integration/avif to adapt to the 16KB memory page size required by Android 15.
https://github.com/xuetaotao/libavif/releases/tag/v1.1.0

@ernesto-flores
Copy link

I'm wondering if Glide has any plans to update the com.github.bumptech.glide.avif-integration dependency to add support for 16KB? or should we reopen a new issue for it?

@soundlicious
Copy link

With Android15 being released, that would be good to reopen this issue.

@vigneshvg
Copy link
Contributor

This has been resolved in the latest version of the AVIF dependency. I have created PR #5465 to update the glide integration.

In the meantime, you can get the latest version in your build.gradle like so:

implementation 'org.aomedia.avif.android:avif:1.1.1.14d8e3c4'
implementation ("com.github.bumptech.glide:avif-integration:4.16.0") {
    exclude group: 'org.aomedia.avif.android', module: 'avif'
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants