Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exposing image view on ImageViewTarget #38

Closed
wants to merge 2 commits into from
Closed

Exposing image view on ImageViewTarget #38

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d13841d
Exposing image view on ImageViewTarget
asos-savvasdalkitsis Nov 7, 2013
855a789
Fixing import order
asos-savvasdalkitsis Nov 7, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions library/src/com/bumptech/glide/presenter/target/ImageViewTarget.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package com.bumptech.glide.presenter.target;

import static android.view.ViewGroup.LayoutParams;

import android.graphics.Bitmap;
import android.graphics.drawable.Drawable;
import android.os.Handler;
Expand All @@ -8,8 +10,6 @@
import android.widget.ImageView;
import com.bumptech.glide.presenter.ImagePresenter;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal, but probably best to try to avoid committing formatting changes to the imports so we don't go back and forth each time our editors disagree.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh man, I thought I had fixed those. Let me recommit the change. My IntelliJ is configured like this cause our team is using this ordering.


import static android.view.ViewGroup.LayoutParams;

/**
* A target wrapping an ImageView. Obtains the runtime dimensions of the ImageView.
*/
Expand Down Expand Up @@ -45,6 +45,10 @@ public void startAnimation(Animation animation) {
imageView.startAnimation(animation);
}

public ImageView getImageView() {
return imageView;
}

@Override
public void setImagePresenter(ImagePresenter imagePresenter) {
this.imagePresenter = imagePresenter;
Expand Down