changed the package of Log class to protected and not accessible by apps... #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As long as we're using the hacky static variable to enable/disable log lines, we probably should keep the class accessible to outside projects so people who download the jar can still enable/disable logging. Maybe just rename it to GlideLog or something similar? |
|
If you hit Log.e()/Log.d or whatever instead of android.utils.Log import its pretty common to import glide.Log either the log class should be something like Logger or remove public access. |
|
This was fixed here: e81c2c3 Glide's log class has been removed and you can now use the normal adb shell setprop TAG LEVEL to enable logging for specific classes. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
....