Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to munit 1.0.0-M5 #40

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Update to munit 1.0.0-M5 #40

merged 1 commit into from
Jun 22, 2022

Conversation

armanbilge
Copy link
Collaborator

@armanbilge armanbilge commented Jun 7, 2022

This fixes the lack of MUnit error-reporting, but only for the JSDOM environment which we are currently using for scoverage.

We could make JSDOM the default test environment for local development. In theory this could make debugging failed tests easier, although that should be weighed against the possibility that JSDOM isn't always a faithful representation of browser APIs e.g.

vnode0.test("supports leaving out the `key` argument") { vnode0 =>
assume(
!dom.window.navigator.userAgent.contains("jsdom"),
"This test is broken on JSDOM"
)

@armanbilge armanbilge force-pushed the update/munit-1.0.0-M5 branch from e317533 to 7d53904 Compare June 7, 2022 23:21
@buntec buntec merged commit b15ea35 into main Jun 22, 2022
@armanbilge armanbilge deleted the update/munit-1.0.0-M5 branch June 22, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants