Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minute.steps bug #11

Closed
altamont opened this issue Dec 18, 2019 · 1 comment
Closed

minute.steps bug #11

altamont opened this issue Dec 18, 2019 · 1 comment
Assignees
Labels

Comments

@altamont
Copy link

Hi,

Attached is a screenshot from when I run shinyTimeExample():
shinyTimeExample_bug

You can see that the starting time for the second time input is incorrect. This is related to the minute.steps parameter. When I do not specify this parameter, the input is loaded with the correct value. Looking at your code, I believe the issue lies with the roundTime function.

Thanks for making this package, I enjoy using it.

@burgerga
Copy link
Owner

Sorry for the (very) late reply, my notification settings were all wrong and I didn't get notifications for new issues.

This looks indeed like I need to write some new tests for the roundTime function, thanks for pointing it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants