Added civilian time option for timeInput function

[nick-youngblut]

I've added an option to use civilian (non-military) time (#12). Feel free to change the parameter name to twelve.hour or another name. I don't have much experience with editing the javascript section of shiny widgets, but it appears to work correctly (see attached).

I added a width parameter (#19).

I've also added documentation for the utility functions and also examples for using the civilian time feature.

[burgerga]

Thanks for the pull request! It's quite a substantive change, so I need some time to review it. I will get back to you ;)

[burgerga]

Question: does the current time button in the example app work for you (it appears from the screenshots that it does)? For me, that button does update the inputs, but the text on the right doesn't...

[nick-youngblut]

does the current time button in the example app work for you

The text was updating for me... but now it is not, and I don't know why 🫤. Any ideas?

[nick-youngblut]

The issue was due to including input in the change.timeInputBinding binding:

    $(el).on("change.timeInputBinding", "input", function(e) {
      correctInputValue(e.target);
      callback();
    });

changed to:

    $(el).on("change.timeInputBinding", function(e) {
      correctInputValue(e.target);
      callback();
    });

[nick-youngblut]

@burgerga you probably have noticed that changing the AM/PM value in the UI element results in a blank value shown instead of "AM" or "PM" (see attached). It appears to be an issue with setValue and/or subscribe, but I can't figure out the issue. Any ideas?

I should note that textOutput("time_output3") changes very briefly when the AM/PM value is changed to the alternative value (e.g., AM --> PM), but then the value switches back to the starting value (e.g., AM --> PM --> AM; all very quickly).

[nick-youngblut]

@burgerga I figured out the issue: correctInputValue was converting the AM/PM values to 0. I've added an early return to the function if the class is shinytime-civilian.

[nick-youngblut]

@burgerga I just wanted to check in on this PR. Do you have any concerns prior to merging?

[burgerga]

Hi @nick-youngblut, sorry for the late reply, hectic period :/
I am almost done with the pull request, it looks good, great work! I'm making some additional changes such that the specified width applies to the whole shinyTime input group, that way you can align it with other elements.

[burgerga]

By the way, I want to credit this significant contribution, do you object to being listed as package author (see ?person)? (and is your orcid https://orcid.org/0000-0002-7424-5276?)

[nick-youngblut]

@burgerga thanks for the update! I'd be happy to be listed as an author. Yep, that's my ORCID. Thanks!

[burgerga]

Hi @nick-youngblut, can you have a look?
I added the non-exported shinyTime:::shinyTimeDebug() function to preview behavior at different widths in bslib.

[nick-youngblut]

Looks great! Thanks again for adding me as an author.