Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Bash colors #31

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Enable Bash colors #31

merged 1 commit into from
Dec 14, 2020

Conversation

olljanat
Copy link
Member

Enable Bash colors to console like proposed on #30

@olljanat olljanat added the enhancement New feature or request label Dec 14, 2020
@olljanat olljanat added this to the v1.9.0 milestone Dec 14, 2020
Copy link
Collaborator

@tomaswarynyca tomaswarynyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain how the theme of colors would be?

  • Do they come by default?
  • Do they have to be activated?
  • Could you give a picture of how it would look

@olljanat
Copy link
Member Author

Normally on Linux user profiles are created based on /etc/skel folder but because of way how console init works on BurmillaOS it does not happen without these additions.

To be exact those files contains Bash standard styles, etc settings and they are provided by its apt package https://packages.debian.org/buster/amd64/bash/filelist Coloring text example on ls -l command is just one of the things which comes part of it.

Not front of computer now but you get idea example from this one https://linoxide.com/linux-command/set-colors-for-ls-command/

@olljanat
Copy link
Member Author

Btw. You can test how it works by copying those files to user profile and login again to machine.

Copy link
Collaborator

@tomaswarynyca tomaswarynyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the operation has been clarified, it is a brilliant contribution @olljanat

@tomaswarynyca tomaswarynyca merged commit 93de612 into v1.9.x Dec 14, 2020
@olljanat olljanat deleted the feat/enable-colors branch December 14, 2020 03:46
@dgiebert
Copy link

Should we create a page in the documentation page to keep track of all the changes for the upcoming release ?

@olljanat
Copy link
Member Author

I published first release version now as it looks working correctly on all platforms which I tested and upgrade works too. It have up to date release notes on https://github.com/burmilla/os/releases/tag/v1.9.0

But we probably should write some migration guide #7 which can then explain more about how BurmillaOS differs now and will differ on future from RancherOS. So high level expiations can be found from Projects view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants