Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make printing of incident pages look better #1382

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

srabraham
Copy link
Member

This makes printed version of an incident page (or any other page) look much more presentable than it looks now. I'm still kind of bad at CSS and Bootstrap 3 (and who really cares to learn?), and the result now is imperfect, but it's much better.

I'm doing a few things:

  • stopping the restriction of the site's CSS to "screen", so that it applies to "print" as well
  • hiding data entry fields (the "no-print" class)
  • stopping flex-container columns from stacking, but rather having them stay side-by-side

Before and after are below:

image

image

This makes printed version of an incident page (or any other page)
look much more presentable than it would now. I'm still kind of
bad at CSS and Bootstrap 3 (and who really wants to learn?), and
the result now is imperfect, but it's much better.
Copy link
Contributor

github-actions bot commented Nov 7, 2024

⚠️ Optional matrix job Py:3.14.0-alpha.1 - ubuntu-latest failed ⚠️

  • tox prefix: test
  • exit status: 1

@@ -57,6 +57,10 @@ a.navbar-brand>img {
flex: 2;
}

.list-group {
margin-bottom: 8px;
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was 20px before, and that was visually a lot, even for screen (and worse on print). Note this is the gray area between "LNT compliance" and "Add" on this screenshot, and the screenshot shows 8px

image

@srabraham srabraham merged commit 2b6f76c into master Nov 8, 2024
13 checks passed
@srabraham srabraham deleted the 2024-11-07-print branch November 8, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant