Fix readme on backend insertion #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecarrara
reviewed
Jul 13, 2023
README.md
Outdated
| @@ -33,6 +33,7 @@ third_party_api_rate_limit_bucket = SimpleTokenBucket( | |||
| name="third_party_api", | |||
| bucket_size=3, | |||
| interval=10, | |||
| backend=RedisBackend(<<REDIS-CLIENT-OBJECT>>) | |||
There was a problem hiding this comment.
We should use the from_url classmethod here.
Suggested change
| backend=RedisBackend(<<REDIS-CLIENT-OBJECT>>) | |
| backend=RedisBackend.from_url("redis://localhost/0") |
There was a problem hiding this comment.
Changed. I also put 6379 port just to be more clear about it
vidalmatheus
force-pushed
the
fix-readme-on-backend-insertion
branch
from
bec1e86 to
dee891c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.